Make inferable arguments implicit in Product.Indexed.{commute,unqiue}#459
Merged
JacquesCarette merged 3 commits intomasterfrom Mar 3, 2025
Merged
Make inferable arguments implicit in Product.Indexed.{commute,unqiue}#459JacquesCarette merged 3 commits intomasterfrom
JacquesCarette merged 3 commits intomasterfrom
Conversation
JacquesCarette
approved these changes
Mar 3, 2025
| ψ⇒ i C.∘ K⇒ ∎ | ||
| Keq : {i : ∃₂ J._⇒_} → ϕ⇒ i C.∘ K⇒ C.≈ ψ⇒ i C.∘ K⇒ | ||
| Keq = begin | ||
| _ C.∘ K⇒ ≈⟨ OP.commute ⟩ |
Collaborator
There was a problem hiding this comment.
I'm very happy to remove inferable things 'on the right' but less so on the left (no need to revert these here - just a general comment.) Stuff on the left serves as documentation.
Member
Author
There was a problem hiding this comment.
This change was at least in part justifying to myself that the arguments could be inferred and hence were safe to remove
Collaborator
There was a problem hiding this comment.
On the left of most equational proofs, you can replace everything by _ and it still works...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing to slowly work through a series of nits