Merged
Conversation
Collaborator
|
Thanks for the fixes, and all the remarks about the CI. All of these should be fixed indeed. [I need some co-maintainers, I'm having a hard time keeping up during teaching terms.] |
JacquesCarette
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prepare for use with Agda 2.8.0, nothing much is needed to be done.
Agda has an improved check for the
UselessPrivateso it found some:privates that Agda-2.8.0 warns aboutWhen I saved a file my editor removed trailing whitespace. So I did this systematically with
fix-whitespace $(find -name "*.agda")..agdafilesIf you don't like this cleanup, I can remove this commit again.
Btw, your CI is on some older GHC. This could be bumped.
It is also on Agda-2.6.4 when we already have 2.7.0.1 for quite a while...