add Pushout Colimit proofs #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zlqrvx
force-pushed
the
pushout-colimit
branch
from
56d8ffc to
8b6adcc
Compare
Member
|
This should be rebased onto master to get CI to run. |
zlqrvx
force-pushed
the
pushout-colimit
branch
from
8b6adcc to
666e88c
Compare
JacquesCarette
requested changes
Nov 16, 2025
Collaborator
JacquesCarette
left a comment
JacquesCarette
left a comment
There was a problem hiding this comment.
Mostly needs more precise use of using, otherwise this looks good, thanks.
|
|
||
| module Categories.Diagram.Pushout.Colimit {o ℓ e} (C : Category o ℓ e) where | ||
|
|
||
| open import Categories.Category.Instance.Span |
Collaborator
There was a problem hiding this comment.
modern agda-categories style has using clauses for all open import (unless they actually import everything).
|
|
||
| private | ||
| module C = Category C | ||
| open Category C |
Collaborator
There was a problem hiding this comment.
What are you using from this open?
zlqrvx
force-pushed
the
pushout-colimit
branch
from
666e88c to
acfa016
Compare
Contributor
Author
|
Thanks for the feedback. Hopefully this style is better now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds proofs that pushouts are colimits, using duality and the already proven results that pullbacks are limits described by this issue.
Hopefully this proof is the right approach and is useful. Any suggestions are welcome.