[ refactor ] deprecate Algebra.Structures.IsGroup.{uniqueˡ-⁻¹|uniqueʳ-⁻¹} with knock-ons for Algebra.Module.*#2571
Merged
MatthewDaggitt merged 17 commits intoagda:masterfrom Mar 31, 2025
Conversation
Taneb
reviewed
Feb 4, 2025
JacquesCarette
approved these changes
Feb 8, 2025
MatthewDaggitt
approved these changes
Feb 19, 2025
MatthewDaggitt
approved these changes
Mar 3, 2025
Collaborator
Author
|
Latest commit e12f942 updates the PR to propagate 'corresponding' changes to Algebra.Module.Structures and Algebra.Module.Properties.*, with suitable additional modules in the latter hierarchy, and 'corresponding' name choices for |
jamesmckinna
changed the title
Algebra.Structures.IsGroup.{uniqueˡ-⁻¹|uniqueʳ-⁻¹}Algebra.Structures.IsGroup.{uniqueˡ-⁻¹|uniqueʳ-⁻¹} with knock-ons for Algebra.Module.*
MatthewDaggitt
approved these changes
Mar 27, 2025
Collaborator
MatthewDaggitt
left a comment
MatthewDaggitt
left a comment
There was a problem hiding this comment.
Apart from my single comment, looks good!
jamesmckinna
commented
Mar 27, 2025
Collaborator
Author
|
Phew, I think that's all fixed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a v2.3-compatible non-
breakingfix for theGroupuniqueness of inverses part of #2502 , avoiding the larger-scale v3.0 structural changes proposed there.NB. the wrinkle is that an
Bundles.AbelianGrouphas to be created on the fly in order to exploit itsProperties, but that can (perhaps!?) be eliminated as part of a downstream refactoring. UPDATED have now managed to eliminate this thanks to the prompt from @MatthewDaggitt below!