[imports] Data.List.Effectful.* .. Relation.Nullary#2624
Merged
jamesmckinna merged 3 commits intoagda:masterfrom Feb 28, 2025
Merged
[imports] Data.List.Effectful.* .. Relation.Nullary#2624jamesmckinna merged 3 commits intoagda:masterfrom
Data.List.Effectful.* .. Relation.Nullary#2624jamesmckinna merged 3 commits intoagda:masterfrom
Conversation
JacquesCarette
requested changes
Feb 26, 2025
JacquesCarette
changed the title
Data.List.Effectful.* .. Relation.Nullary
jamesmckinna
requested changes
Feb 26, 2025
Collaborator
jamesmckinna
left a comment
jamesmckinna
left a comment
There was a problem hiding this comment.
Additional (nitpicking, but necessary eg re whitespace) comments on the 'cleaning' commits
src/Data/List/Relation/Binary/Infix/Homogeneous/Properties.agda
Outdated
Show resolved
Hide resolved
jamesmckinna
requested changes
Feb 27, 2025
Collaborator
jamesmckinna
left a comment
jamesmckinna
left a comment
There was a problem hiding this comment.
yet more nitpicking, sorry.
JacquesCarette
approved these changes
Feb 28, 2025
jamesmckinna
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor import statements for clarity and consistency, and introduce a new module for irrelevant types in the relation library.