Skip to content

[Refractor] contradiction over ⊥-elim in#2667

Merged
JacquesCarette merged 1 commit intoagda:masterfrom
jmougeot:contradiction15
Mar 13, 2025
Merged

[Refractor] contradiction over ⊥-elim in#2667
JacquesCarette merged 1 commit intoagda:masterfrom
jmougeot:contradiction15

Conversation

@jmougeot
Copy link
Contributor

No description provided.

Copy link
Collaborator

@JacquesCarette JacquesCarette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove import of ⊥-elim ? Rest looks good.

@jmougeot
Copy link
Contributor Author

I can't remove it in this file since it's still use in the file :
∈-remove x∈xs y∈xs x≉y = fromInj₂ (⊥-elim ∘′ x≉y) (remove-inv x∈xs y∈xs)

@jmougeot jmougeot requested a review from JacquesCarette March 13, 2025 20:54
@JacquesCarette
Copy link
Collaborator

you might be able to replace that with flip contradiction but I'm not sure if that would make things clearer. So I think it best to leave it as is, at least for this pass.

@JacquesCarette JacquesCarette added this pull request to the merge queue Mar 13, 2025
Merged via the queue into agda:master with commit 427d373 Mar 13, 2025
2 checks passed
jamesmckinna pushed a commit to jamesmckinna/agda-stdlib that referenced this pull request Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants