Skip to content

[ fix ] issue #2918 #2920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesmckinna merged 2 commits into from
Jan 26, 2026
Merged

[ fix ] issue #2918 #2920

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7830c7f
[ fix ] issue #2918
jamesmckinna Jan 24, 2026
8dcac50
[ add ] deprecation warning
jamesmckinna Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ Bug-fixes

* Fix a typo in `Algebra.Morphism.Construct.DirectProduct`.

* Fix a typo in `Data.Rational.Properties`: `nonPos*nonPos⇒nonPos` erroneously named,
corrected to `nonPos*nonPos⇒nonNeg`.

* Fix a typo in `Function.Construct.Constant`.

Non-backwards compatible changes
Expand Down
4 changes: 2 additions & 2 deletions src/Data/Rational/Properties.agda
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1389,8 +1389,8 @@ nonNeg*nonPos⇒nonPos p q = nonPositive $ begin
0ℚ ∎
where open ≤-Reasoning

nonPos*nonPos⇒nonPos : ∀ p .{{_ : NonPositive p}} q .{{_ : NonPositive q}} → NonNegative (p * q)
nonPos*nonPos⇒nonPos p q = nonNegative $ begin
nonPos*nonPos⇒nonNeg : ∀ p .{{_ : NonPositive p}} q .{{_ : NonPositive q}} → NonNegative (p * q)
nonPos*nonPos⇒nonNeg p q = nonNegative $ begin
0ℚ ≡⟨ *-zeroʳ p ⟨
p * 0ℚ ≤⟨ *-monoˡ-≤-nonPos p (nonPositive⁻¹ q) ⟩
p * q ∎
Expand Down