Fix Set indices on datatypes not being caught#442
Merged
jespercockx merged 2 commits intoagda:masterfrom Nov 18, 2025
Merged
Conversation
Member
|
Hmm, it makes sense to make a more explicit distinction between an erased domain and one that is just left implicit in the Haskell code. However, I think it would make more sense to treat the latter as a |
4f67f5c to
6289fd0
Compare
Contributor
Author
|
That does make more sense! I've redone the changes, could you look at them again? |
jespercockx
approved these changes
Nov 18, 2025
Member
|
It's perfect now, thank you for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compileDomTypewould returnDomDroppedfor types universally quantified in Haskell, but the erased indices check would understand that as the type being erased; which is not the case forSetindices, as I understand it. Is this the right solution?I've also added a test for this case.
Fixes #437