Open
Conversation
zeroeightysix
approved these changes
Nov 28, 2025
Contributor
zeroeightysix
left a comment
zeroeightysix
left a comment
There was a problem hiding this comment.
My approval probably doesn't hold a lot of weight, but looks very similar to what I was doing in my tests - so LGTM :)
Member
Author
I'd say it holds a lot of weight since you're the one who's actually implementing the real meat of this feature :) |
Member
Author
|
There should probably be some documentation for this feature (as well as a number of other features that were added somewhat recently such as compile-to). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it says on the tin, this PR implements support for GADT syntax for datatypes. It does not actually increase the expressivity of agda2hs (yet).
Might be of interest to @np and @zeroeightysix