Merged
Conversation
Contributor
Author
ecavallo
requested changes
Jul 23, 2025
Collaborator
ecavallo
left a comment
There was a problem hiding this comment.
Contents look good. I have some minor comments mostly about naming.
A question about conventions. Is there any logic to when you use Dagger (e.g. DaggerStr) vs Dag (e.g. DagCat) vs † vs D in names? If not, can we pick one (†?) to use in all names?
Contributor
Author
|
oops I was trying to see what was the requested change and accidentally clicked on re-request review. |
Contributor
Author
|
@ecavallo I've made the changes you requested (though GitHub is not showing it for some reason) can this be merged now? |
Collaborator
|
Hey, sorry for the wait. There are a few more name changes I would suggest for uniformity:
Maybe also |
Contributor
Author
|
Done! |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To do: