fixup: make generate-everything.sh predicative#1241
Merged
felixwellen merged 1 commit intomasterfrom Jul 30, 2025
Merged
Conversation
Due to the order in which shells do things, `find > foo` will find `foo`. This means that `generate-everything.sh` puts everything on the table including the table, resulting in a dependency cycle. This change fixes that by excluding `Cubical/Everything.agda` from "everything". Also sorts the modules alphabetically and makes `make listing` display "Checking" messages so we know what it's doing.
Merged
Collaborator
|
Oh yes - many thanks for spotting that! |
Collaborator
|
I'll just merge that, so the links work again as soon as possible. |
Oops, you're right. Sorry about that. |
Member
Author
|
You'll also want to change the link under the repository description at https://github.com/agda/cubical (to https://agda.github.io/cubical/Cubical.Everything.html) |
Collaborator
|
Haven't figured out yet where I can change that. |
Member
Author
|
There's supposed to be a ⚙️ next to it if you've got the rights (which I'm guessing you don't). Maybe @mortberg does? |
Member
Author
|
If not it might be an organisation-level thing, so maybe @andreasabel |
Collaborator
|
Yes, I don't seem to have the rights. |
Collaborator
|
I have fixed it now |
Member
Now you have, @felixwellen . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the order in which shells do things,
find > foowill findfoo. This means thatgenerate-everything.shputs everything on the table including the table, resulting in a dependency cycle.This change fixes that by excluding
Cubical/Everything.agdafrom "everything". Also sorts the modules alphabetically and makesmake listingdisplay "Checking" messages so we know what it's doing.