Use the faster quotient and remainder in the whole library#1284
Open
LorenzoMolena wants to merge 1 commit intoagda:masterfrom
Open
Use the faster quotient and remainder in the whole library#1284LorenzoMolena wants to merge 1 commit intoagda:masterfrom
LorenzoMolena wants to merge 1 commit intoagda:masterfrom
Conversation
…ssary properties and that is equivalent to the previous implementations ; add examples of computations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the names of
quotient_/_,remainder_/_, andmod, so that the more efficient implementations become the new default, while the less efficient ones are written with a'.To achieve this, I ported the proofs from the standard library, and I also proved the equality of the two implementations by showing the uniqueness of the quotient-remainder pair under some constraints.
I left the old proofs for reference, but if it seems reasonable, I can remove them, as they are no longer used.
Additionally, two more tests have been added to the
Data.Fin.Arithmeticmodule.