Conversation
…`/`^types` Turborepo dependencies
|
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
Author
Merge activity
|
eXamadeus
deleted the
julian/06-14-update_scoped_facet_test_to_use_scope_name_identity_and_add_test___types_turborepo_dependencies
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The test for scoped facet publishing was using the legacy bare-slash form (
acme/cowsay) as the manifest name, which is no longer a valid identity according toFacetManifestSchema. Valid identities are either an unscoped slug (cowsay) or a scoped@scope/nameform (@acme/cowsay).Details
The test is updated to use
@acme/cowsayas the facet name, and the expected URL reflects the current client behavior whereopenapi-fetchpercent-encodes the entire identity (@acme/cowsay→%40acme%2Fcowsay) rather than using a literal-slash scoped route (/v0/facets/@scope/name/...). A TODO comment documents that the registry has already moved to literal-slash scoped routes, but the engine registry client still uses the single{name}route parameter. The assertion is intentionally written to match current behavior and is expected to be updated when the scoped-route migration for publish/resolve/download lands.Additionally,
turbo.jsonis updated so thattestandtypestasks depend on their upstream equivalents (^testand^types), ensuring dependent packages are tested and type-checked before downstream packages.Verification
CI.