Conversation
🦋 Changeset detectedLatest commit: 7069445 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7069445aee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "viper-plans": "0.2.0", | ||
| "cowsay": "0.2.0" | ||
| "cowsay": "0.2.0", | ||
| "@julian/review-openspec-design": "1.0.0" |
There was a problem hiding this comment.
This adds @julian/review-openspec-design to the repo's project-level facets.json even though the reviewed change is only about facet whoami output. Any checkout that runs facet install will treat this manifest entry, plus the new lockfile entry, as desired project tooling and materialize the extra review-openspec-design skill, silently changing contributors' installed facets. Please drop the manifest/lockfile edits unless this new facet is an intentional repo dependency.
Useful? React with 👍 / 👎.
Merge activity
|
eXamadeus
deleted the
julian/06-15-add_julian_review-openspec-design_facet_and_show_registry_url_in_whoami_output
branch
This PR was auto-generated by the release workflow. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## agent-facets@0.21.1 ### Patch Changes - [#342](#342) [`3314057`](3314057) Thanks [@eXamadeus](https://github.com/eXamadeus)! - Add in registry URL to `facet whoami` Co-authored-by: the-faceter[bot] <272408671+the-faceter[bot]@users.noreply.github.com>
This PR was auto-generated by the release workflow. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## agent-facets@0.21.1 ### Patch Changes - [#342](#342) [`3314057`](3314057) Thanks [@eXamadeus](https://github.com/eXamadeus)! - Add in registry URL to `facet whoami`
Why
Users running
facet whoamihad no way to see which registry URL their CLI was pointed at, making it harder to debug configuration issues or confirm they're talking to the right environment.Details
The
registryline is printed usinggetRegistryBaseUrl(), which falls back tohttps://api.facet.cafewhenFACET_REGISTRY_URLis not set. A new test covers this fallback behavior explicitly.Verification
New tests added for both the case where
FACET_REGISTRY_URLis set and where it falls back to the default. CI covers it.