Skip to content

feat(deslop): add infrastructure-without-implementation detection (#105) #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avifenesh merged 11 commits into from
Jan 21, 2026
Merged

feat(deslop): add infrastructure-without-implementation detection (#105) #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1ac9e95
feat(deslop): add infrastructure-without-implementation detection (#105)
avifenesh Jan 21, 2026
52a2f0d
fix: address review feedback (iteration 1)
avifenesh Jan 21, 2026
d9fd7c6
perf: move regex compilation outside inner loop
avifenesh Jan 21, 2026
8e91ea9
docs: update documentation for infrastructure detection (#105)
avifenesh Jan 21, 2026
af8fba9
fix: remove global flag from usage regex patterns
avifenesh Jan 21, 2026
8d17288
fix: update severity to 'high' for consistency with CHANGELOG
avifenesh Jan 21, 2026
b4cb49a
fix(tests): normalize directory paths in mock fs implementations
avifenesh Jan 21, 2026
20dbbeb
fix(tests): properly normalize directory paths in all mock fs impleme…
avifenesh Jan 21, 2026
bdfe475
fix(infrastructure): add module.Method() patterns for Python, Go, Rust
avifenesh Jan 21, 2026
02a89e1
fix: address PR review comments
avifenesh Jan 21, 2026
6eb6031
test: update verdict expectations from LOW to HIGH
avifenesh Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- All patterns have severity `high` and autoFix `flag` (requires manual review)
- Test files are excluded to prevent false positives

- **Infrastructure-Without-Implementation Detection** - New pattern for detecting unused infrastructure components (#105)
- Detects infrastructure components that are configured but never used
- Supports JavaScript, Python, Go, and Rust
- Identifies unused database clients, cache connections, API clients, queue connections, event emitters
- Tracks usage across files to avoid false positives
- Excludes exported/module.exports patterns (intentional infrastructure setup files)
- Severity `high`, autoFix `flag` (requires manual review)

Copilot AI Jan 21, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The severity is documented as 'high' in the CHANGELOG, but the actual pattern definition in all slop-patterns.js files sets severity to 'low'. This inconsistency should be corrected to match the implementation.

Suggested change
- Severity `high`, autoFix `flag` (requires manual review)
- Severity `low`, autoFix `flag` (requires manual review)

Copilot uses AI. Check for mistakes.
- New `analyzeInfrastructureWithoutImplementation()` function in slop-analyzers.js
- Focused test suite covering key scenarios and edge cases

### Fixed
- **findMatchingBrace** - Now skips comments to avoid breaking on quotes/apostrophes in comment text (e.g., "it's", "we're")
- **Reality Check Output Size** - Condensed collector output to ~700 lines/~4.5k tokens (was thousands of lines)
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ Remove debugging code, old TODOs, and AI slop from your codebase.
- Placeholder functions (`return 0`, `todo!()`, `raise NotImplementedError`)
- Excessive documentation (JSDoc >3x function body)
- Phantom references (issue/PR mentions, file path references in comments)
- Infrastructure components configured but never used (unused DB clients, caches, API clients)

---

Expand Down
Loading
Loading