Add MiniMax thinking modes to OpenCode - #384
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
There was a problem hiding this comment.
Pull request overview
Adds MiniMax provider-specific thinking-mode handling to the OpenCode chat.params hook so MiniMax-M3 uses adaptive/disabled based on the agent thinking tier (without token budgets), while MiniMax-M2.7 remains unchanged. Also updates reference docs and adds focused test coverage.
Changes:
- Update OpenCode plugin to set
options.thinking.typetoadaptiveordisabledfor MiniMax-M3 based on the agent budget tier, withoutbudgetTokens. - Document MiniMax thinking behavior in the OpenCode reference.
- Add a dedicated Jest test that exercises MiniMax-M3 (adaptive/disabled) and MiniMax-M2.7 (no override), plus add
typescriptas a devDependency to transpile the TS plugin in-test.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Adds typescript devDependency to support TS transpilation in the new Jest test. |
| package-lock.json | Locks the new typescript devDependency resolution. |
| CHANGELOG.md | Records the OpenCode MiniMax thinking-mode behavior update and associated tests in Unreleased. |
| agent-docs/OPENCODE-REFERENCE.md | Documents MiniMax-M3 (adaptive/disabled) vs MiniMax-M2.7 (always-on default) thinking behavior and “no fixed token budget”. |
| adapters/opencode-plugin/index.ts | Implements MiniMax model-aware thinking selection for MiniMax-M3 while preserving MiniMax-M2.7 defaults. |
| tests/opencode-plugin-thinking.test.js | Adds targeted coverage for the MiniMax thinking-mode selection logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks for the contribution. We are closing this without merging. OpenCode already provides native MiniMax-M3 thinking defaults and variants, and this implementation can overwrite a user's explicit runtime thinking selection after OpenCode merges its options; the tests do not cover that case. We also do not accept unsolicited changes submitted through high-volume automated provider-promotion campaigns. Please do not submit further campaign-generated PRs to this repository. |
Reason: Apply the supported MiniMax thinking behavior per model in the OpenCode chat hook.
Changes:
Checks:
npm test -- --runInBand __tests__/opencode-plugin-thinking.test.jsgit diff --check origin/main...HEAD