Skip to content

Add MiniMax thinking modes to OpenCode - #384

Closed
octo-patch wants to merge 1 commit into
agent-sh:mainfrom
octo-patch:octo/20260801-parameter-refresh-recvqnGwgefhSa
Closed

Add MiniMax thinking modes to OpenCode#384
octo-patch wants to merge 1 commit into
agent-sh:mainfrom
octo-patch:octo/20260801-parameter-refresh-recvqnGwgefhSa

Conversation

@octo-patch

Copy link
Copy Markdown

Reason: Apply the supported MiniMax thinking behavior per model in the OpenCode chat hook.

Changes:

  • Use adaptive or disabled thinking for MiniMax-M3 based on the agent thinking tier without a fixed token budget.
  • Preserve MiniMax-M2.7's always-on default behavior.
  • Add focused plugin coverage and reference documentation for both model behaviors.

Checks:

  • npm test -- --runInBand __tests__/opencode-plugin-thinking.test.js
  • git diff --check origin/main...HEAD
  • Secret scan of the committed upstream diff (no matches)

Copilot AI review requested due to automatic review settings August 1, 2026 05:13
@octo-patch
octo-patch requested a review from avifenesh as a code owner August 1, 2026 05:13
@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds MiniMax provider-specific thinking-mode handling to the OpenCode chat.params hook so MiniMax-M3 uses adaptive/disabled based on the agent thinking tier (without token budgets), while MiniMax-M2.7 remains unchanged. Also updates reference docs and adds focused test coverage.

Changes:

  • Update OpenCode plugin to set options.thinking.type to adaptive or disabled for MiniMax-M3 based on the agent budget tier, without budgetTokens.
  • Document MiniMax thinking behavior in the OpenCode reference.
  • Add a dedicated Jest test that exercises MiniMax-M3 (adaptive/disabled) and MiniMax-M2.7 (no override), plus add typescript as a devDependency to transpile the TS plugin in-test.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Adds typescript devDependency to support TS transpilation in the new Jest test.
package-lock.json Locks the new typescript devDependency resolution.
CHANGELOG.md Records the OpenCode MiniMax thinking-mode behavior update and associated tests in Unreleased.
agent-docs/OPENCODE-REFERENCE.md Documents MiniMax-M3 (adaptive/disabled) vs MiniMax-M2.7 (always-on default) thinking behavior and “no fixed token budget”.
adapters/opencode-plugin/index.ts Implements MiniMax model-aware thinking selection for MiniMax-M3 while preserving MiniMax-M2.7 defaults.
tests/opencode-plugin-thinking.test.js Adds targeted coverage for the MiniMax thinking-mode selection logic.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@avifenesh

Copy link
Copy Markdown
Collaborator

Thanks for the contribution. We are closing this without merging. OpenCode already provides native MiniMax-M3 thinking defaults and variants, and this implementation can overwrite a user's explicit runtime thinking selection after OpenCode merges its options; the tests do not cover that case.

We also do not accept unsolicited changes submitted through high-volume automated provider-promotion campaigns. Please do not submit further campaign-generated PRs to this repository.

@avifenesh avifenesh closed this Aug 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants