fix: use single-arg limitedParallelism for coroutines 1.8 compat#77
Open
frninja wants to merge 1 commit intoagentclientprotocol:masterfrom
Open
fix: use single-arg limitedParallelism for coroutines 1.8 compat#77frninja wants to merge 1 commit intoagentclientprotocol:masterfrom
frninja wants to merge 1 commit intoagentclientprotocol:masterfrom
Conversation
The two-argument overload `limitedParallelism(Int, String)` was added in kotlinx-coroutines 1.9.0. IntelliJ Platform 2024.1–2025.1 bundles coroutines 1.7–1.8, causing NoSuchMethodError at runtime when ACP SDK is used as a plugin dependency. The `name` parameter is optional and purely for debugging. Dropping it restores compatibility with coroutines 1.6+ while keeping the same runtime behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
@nerzhulart Hi, Artem! Could you please take a look and merge? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
limitedParallelism(parallelism = 1, name = "MessageProcessor")withlimitedParallelism(parallelism = 1)inProtocol.ktProblem
When ACP SDK is used as an IntelliJ plugin dependency,
Protocolconstructor crashes at runtime:IntelliJ plugins must use the bundled coroutines library — they cannot bundle their own version. The bundled versions by IDE release:
limitedParallelism?Fix
The
nameparameter is optional and purely for debugging. The single-argumentlimitedParallelism(Int)is available since coroutines 1.6.0 and works on all IntelliJ Platform versions.