cel: add url.{encode,decode} functions#1884
Open
howardjohn wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds URL percent-encoding helpers to the CEL function surface, enabling policies/logging expressions to encode/decode URL components without relying on form.encode/decode.
Changes:
- Register new CEL functions
url.encodeandurl.decodeinagent-celx. - Implement URL component percent-encoding/decoding using
percent-encoding. - Document the new functions and add unit tests.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| schema/cel-functions.md | Documents url.encode / url.decode usage and semantics. |
| crates/celx/src/general.rs | Implements and registers the new CEL URL encode/decode functions. |
| crates/celx/src/function_tests.rs | Adds unit tests covering URL encode/decode behavior and failure cases. |
| crates/celx/Cargo.toml | Adds percent-encoding as a dependency for agent-celx. |
| Cargo.lock | Records the new dependency in the lockfile. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| const URL_COMPONENT_ENCODE_SET: &AsciiSet = &CONTROLS | ||
| .add(b' ') |
Comment on lines
+121
to
+122
| Ok( | ||
| percent_encode(v.as_bytes_pre_materialized()?, URL_COMPONENT_ENCODE_SET) |
howardjohn
force-pushed
the
cel/url-enc-dec
branch
from
c0f66c1 to
fd420fc
Compare
Signed-off-by: John Howard <john.howard@solo.io>
howardjohn
force-pushed
the
cel/url-enc-dec
branch
from
fd420fc to
de49173
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.