Renamed files to kebab-case - core - services - part 2#8
Conversation
🤖 Augment PR SummarySummary: This PR continues the core/services rename effort by converting many server-side service modules to kebab-case filenames and updating all affected imports. Changes:
Technical Notes: The change is primarily mechanical but correctness depends on every updated import matching an on-disk filename (especially on case-sensitive filesystems). 🤖 Was this summary useful? React with 👍 or 👎 |
| const EmailEventProcessor = require('../email-service/EmailEventProcessor'); | ||
| const MailgunProvider = require('./EmailAnalyticsProviderMailgun'); | ||
| const EmailAnalyticsService = require('./email-analytics-service'); | ||
| const EmailEventStorage = require('../email-service/email-event-storage'); |
There was a problem hiding this comment.
require('../email-service/email-event-storage') doesn’t match an existing file under services/email-service (it’s currently EmailEventStorage.js), so this will fail on case-sensitive filesystems. Same issue for email-event-processor.
Other Locations
ghost/core/core/server/services/email-analytics/email-analytics-service-wrapper.js:13
🤖 Was this useful? React with 👍 or 👎
| const WellKnownController = require('./controllers/well-known-controller'); | ||
|
|
||
| const {EmailSuppressedEvent} = require('../../email-suppression-list/email-suppression-list'); | ||
| const MagicLink = require('../../lib/magic-link/magic-link'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR from agentic-review-benchmarks#7