Skip to content

Align zh translations with China mainland terminology.#8

Open
tomerqodo wants to merge 2 commits intocoderabbit_full_base_align_zh_translations_with_china_mainland_terminology_pr8from
coderabbit_full_head_align_zh_translations_with_china_mainland_terminology_pr8
Open

Align zh translations with China mainland terminology.#8
tomerqodo wants to merge 2 commits intocoderabbit_full_base_align_zh_translations_with_china_mainland_terminology_pr8from
coderabbit_full_head_align_zh_translations_with_china_mainland_terminology_pr8

Conversation

@tomerqodo
Copy link
Copy Markdown

@tomerqodo tomerqodo commented Jan 29, 2026

Benchmark PR from agentic-review-benchmarks#8

Summary by CodeRabbit

  • Localization
    • Removed Chinese translation support for comments feature
    • Updated Chinese translations across portal and main locale files for improved clarity and consistency in subscription messaging, user preferences, and interface terminology

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 29, 2026

📝 Walkthrough

Walkthrough

The PR removes a Chinese locale file for comments and updates Chinese translations across other locale files with improved phrasing, terminology consistency, and more natural expression for UI, subscription, and account-related strings.

Changes

Cohort / File(s) Summary
Chinese Locale Updates
ghost/i18n/locales/zh/comments.json, ghost/i18n/locales/zh/ghost.json, ghost/i18n/locales/zh/portal.json
Deleted comments.json (74 lines of Chinese translations) and refined translations in ghost.json and portal.json for improved phrasing across UI, subscription, newsletter, email, and account-related strings (30 lines changed total).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Hop along, dear translations flow,
Chinese words now shine with natural glow,
Comments gone, but phrases refined,
Better phrasing, better designed! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Align zh translations with China mainland terminology' accurately describes the main objective of the pull request, which involves updating Chinese translations across multiple locale files for better alignment with mainland Chinese terminology and phrasing conventions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@ghost/i18n/locales/zh/portal.json`:
- Line 9: Translation for the key "{memberEmail} will no longer receive
{newsletterName} newsletter." removed the {newsletterName} placeholder; update
the value to include the {newsletterName} variable (e.g.,
"{memberEmail}将不会再收到{newsletterName}新闻信。") so the runtime interpolation of
newsletterName remains intact in the translation for that key.

"{amount} off forever.": "永久减免{amount}",
"{discount}% discount": "{discount}% 折扣",
"{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到{newsletterName}的新闻信。",
"{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到新闻信。",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Preserve the {newsletterName} placeholder to avoid losing context.

The key includes {newsletterName}, but the translation drops it, so users won’t know which newsletter was unsubscribed.

🛠️ Suggested fix
-    "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到新闻信。",
+    "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到{newsletterName}新闻信。",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到新闻信",
"{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到{newsletterName}新闻信",
🤖 Prompt for AI Agents
In `@ghost/i18n/locales/zh/portal.json` at line 9, Translation for the key
"{memberEmail} will no longer receive {newsletterName} newsletter." removed the
{newsletterName} placeholder; update the value to include the {newsletterName}
variable (e.g., "{memberEmail}将不会再收到{newsletterName}新闻信。") so the runtime
interpolation of newsletterName remains intact in the translation for that key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant