Align zh translations with China mainland terminology.#8
Conversation
📝 WalkthroughWalkthroughThe PR removes a Chinese locale file for comments and updates Chinese translations across other locale files with improved phrasing, terminology consistency, and more natural expression for UI, subscription, and account-related strings. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@ghost/i18n/locales/zh/portal.json`:
- Line 9: Translation for the key "{memberEmail} will no longer receive
{newsletterName} newsletter." removed the {newsletterName} placeholder; update
the value to include the {newsletterName} variable (e.g.,
"{memberEmail}将不会再收到{newsletterName}新闻信。") so the runtime interpolation of
newsletterName remains intact in the translation for that key.
| "{amount} off forever.": "永久减免{amount}", | ||
| "{discount}% discount": "{discount}% 折扣", | ||
| "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到{newsletterName}的新闻信。", | ||
| "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到新闻信。", |
There was a problem hiding this comment.
Preserve the {newsletterName} placeholder to avoid losing context.
The key includes {newsletterName}, but the translation drops it, so users won’t know which newsletter was unsubscribed.
🛠️ Suggested fix
- "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到新闻信。",
+ "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到{newsletterName}新闻信。",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到新闻信。", | |
| "{memberEmail} will no longer receive {newsletterName} newsletter.": "{memberEmail}将不会再收到{newsletterName}新闻信。", |
🤖 Prompt for AI Agents
In `@ghost/i18n/locales/zh/portal.json` at line 9, Translation for the key
"{memberEmail} will no longer receive {newsletterName} newsletter." removed the
{newsletterName} placeholder; update the value to include the {newsletterName}
variable (e.g., "{memberEmail}将不会再收到{newsletterName}新闻信。") so the runtime
interpolation of newsletterName remains intact in the translation for that key.
Benchmark PR from agentic-review-benchmarks#8
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.