Renamed files to kebab-case - core - services - part 2#9
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 092595d54e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const EmailEventStorage = require('../email-service/email-event-storage'); | ||
| const EmailEventProcessor = require('../email-service/email-event-processor'); |
There was a problem hiding this comment.
Point email analytics requires to existing filenames
These two require paths were changed to kebab-case, but the corresponding files were not renamed in this commit (they still exist as EmailEventStorage.js and EmailEventProcessor.js). On a case-sensitive filesystem (typical Linux production), Node will throw "Cannot find module" when EmailAnalyticsServiceWrapper.init() runs, preventing the email analytics worker from starting. Either rename the email-service files or keep the original casing in the require paths.
Useful? React with 👍 / 👎.
Benchmark PR from agentic-review-benchmarks#7