Renamed files to kebab-case - core - services - part 2#9
Conversation
There was a problem hiding this comment.
Pull request overview
This PR renames service files from PascalCase to kebab-case as part of a systematic refactoring effort (part 2). The changes update file names and all corresponding import/require statements across test files and source code.
Changes:
- Renamed approximately 100+ service class files from PascalCase (e.g.,
MailgunClient.js) to kebab-case (e.g.,mailgun-client.js) - Updated all import/require statements in test files to reference the renamed files
- Updated all require statements in source files to reference the renamed files
Reviewed changes
Copilot reviewed 137 out of 198 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Test files (40+ files) | Updated require statements to reference renamed service files |
| Source service files (60+ files) | Updated require statements and created new files with kebab-case names |
| Index files | Updated require statements to reference renamed service modules |
| API endpoints | Updated require statements for renamed service dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+19
| const {Router} = require('express') | ||
| const body = require('body-parser') | ||
| const errors = require('@tryghost/errors') | ||
| const logging = require('@tryghost/logging') | ||
|
|
||
| const PaymentsService = require('./services/payments-service') | ||
| const TokenService = require('./services/token-service') | ||
| const GeolocationService = require('./services/geolocation-service') | ||
| const MemberBREADService = require('./services/member-bread-service') | ||
| const MemberRepository = require('./repositories/member-repository') | ||
|
|
||
| const EventRepository = require('./repositories/event-repository'); | ||
| const ProductRepository = require('./repositories/product-repository'); | ||
| const RouterController = require('./controllers/router-controller'); | ||
| const MemberController = require('./controllers/member-controller'); | ||
| const WellKnownController = require('./controllers/well-known-controller'); | ||
|
|
||
| const {EmailSuppressedEvent} = require('../../email-suppression-list/email-suppression-list'); | ||
| const MagicLink = require('../../lib/magic-link/magic-link'); |
There was a problem hiding this comment.
Missing semicolons at the end of require statements. Lines 1-11 and 14-19 are missing semicolons, which is inconsistent with the codebase convention. All other files in this PR use semicolons consistently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR from agentic-review-benchmarks#7