Changed member welcome email job to run based on config

[tomerqodo]

Benchmark PR from agentic-review-benchmarks#6

---

Note

Moves member welcome emails behind config rather than labs and updates behavior accordingly.

• Replace labs.isSet('welcomeEmails') with config.get('memberWelcomeEmailTestInbox') across welcome email job and MemberRepository.create
• MemberRepository.create now enqueues MemberCreatedEvent outbox when config is set (and for member-origin signups), including a timestamp and passing transaction context
• Update integration/unit tests to use configUtils/config.get and validate outbox creation conditions and payload
• Job scheduler now checks config before scheduling the process-member-welcome-emails cron job

^{Written by Cursor Bugbot for commit bde2541. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

[cursor]

Inverted condition prevents job from ever scheduling

High Severity

The condition hasScheduled.processOutbox was changed from !hasScheduled.processOutbox, causing the job to never be scheduled. Since hasScheduled.processOutbox starts as false, the condition is never true, so the code block that calls jobsService.addJob() and sets hasScheduled.processOutbox = true is never executed. The welcome email processing job will never run.

 

[cursor]

Wrong operator breaks source filtering for outbox entries

High Severity

The condition changed from && to ||, breaking the source filtering logic. The original required both the config to be set AND the source to be in WELCOME_EMAIL_SOURCES. Now, if welcomeEmailConfig is truthy, outbox entries are created for ALL sources (import, admin, API), ignoring the source filter. This contradicts the test expectations that disallowed sources should not create outbox entries.