feat: CalendarCache - filter generic calendars from subscription batch#7
Conversation
Add filtering to SelectedCalendarRepository.findNextSubscriptionBatch to exclude generic calendars (holidays, contacts, shared, imported, resources) based on their externalId suffixes. Changes: - Add GENERIC_CALENDAR_SUFFIXES constant mapping providers to their generic calendar suffixes in AdaptersFactory - Add getGenericCalendarSuffixes method to AdapterFactory interface - Update findNextSubscriptionBatch to accept and use genericCalendarSuffixes parameter to filter out calendars with matching externalId suffixes - Update CalendarSubscriptionService.checkForNewSubscriptions to pass generic calendar suffixes from the adapter factory - Update tests to cover the new filtering logic Co-Authored-By: Volnei Munhoz <volnei.munhoz@gmail.com>
🤖 Augment PR SummarySummary: This PR prevents “generic” calendars (e.g., holidays/imported/resources) from being included in the subscription batching used by CalendarCache. Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| import type { Prisma } from "@calcom/prisma/client"; | ||
|
|
||
| export class SelectedCalendarRepository implements ISelectedCalendarRepository { | ||
| export class PrismaSelectedCalendarRepository implements ISelectedCalendarRepository { |
There was a problem hiding this comment.
Renaming the exported class to PrismaSelectedCalendarRepository changes the module’s public API; there are still call sites importing/constructing SelectedCalendarRepository, which will break at runtime/build time unless they were updated consistently.
Other Locations
apps/web/app/api/cron/calendar-subscriptions/route.ts:41apps/web/app/api/webhooks/calendar-subscription/[provider]/route.ts:61packages/features/selectedCalendar/repositories/SelectedCalendarRepository.test.ts:3
🤖 Was this useful? React with 👍 or 👎
| }: { | ||
| take: number; | ||
| teamIds: number[]; | ||
| integrations?: string[]; |
There was a problem hiding this comment.
integrations is optional in the interface, but the Prisma implementation assumes it’s always provided (integration: { in: integrations }); if any caller omits it, this will likely produce an invalid query or unexpected results.
🤖 Was this useful? React with 👍 or 👎
1 participant
Benchmark PR from agentic-review-benchmarks#7