fix(companion): event type links for org user#5
Open
tomerqodo wants to merge 7 commits intocursor_full_base_fixcompanion_event_type_links_for_org_user_pr5from
Conversation
Addresses Cubic AI review feedback (confidence 9/10): The username was hardcoded to 'username' but still used by BasicsTab as a fallback for URL display when bookingUrl is unavailable. This restores the useEffect that fetches the actual username from CalComAPIService.getUsername(). Co-Authored-By: unknown <>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| const [conferencingOptions, setConferencingOptions] = useState<ConferencingOption[]>([]); | ||
| const [conferencingLoading, setConferencingLoading] = useState(false); | ||
| const [eventTypeData, setEventTypeData] = useState<EventType | null>(null); | ||
| const [bookingUrl, setBookingUrl] = useState<string>(""); |
There was a problem hiding this comment.
Booking URL state never populated from fetched event type
High Severity
The bookingUrl state is initialized as an empty string but is never set from eventType.bookingUrl in applyEventTypeData. This causes handlePreview and handleCopyLink to always show "Booking URL not available. Please save the event type first" even when the event type has a valid bookingUrl from the API.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR from agentic-review-benchmarks#5
Note
Updates link handling to rely on API-provided
bookingUrlinstead of constructing URLs, and polishes several UI elements.bookingUrlfor preview/copy/share in event type detail, lists, iOS/web screens, and browser extension; addbookingUrltoEventTypetypes and plumb through components; removebuildEventTypeLinkand related usage; guard actions whenbookingUrlis missingBasicsTabURL field now derives its display prefix frombookingUrlbookingUrlin menus, copy/insert, and preview actions; update cached/type shapes accordinglyWritten by Cursor Bugbot for commit 161a777. Configure here.