refactor: move WebWrapper files from packages/platform to apps/web/modules#9
Conversation
Code Review by Qodo
1. EventRecurringWebWrapper default export
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
| }; | ||
|
|
||
| export default EventRecurringWebWrapper; | ||
| export default EventRecurringWebWrapper; No newline at end of file |
There was a problem hiding this comment.
1. eventrecurringwebwrapper default export 📘 Rule violation ➹ Performance
• apps/web/modules/event-types/components/tabs/recurring/EventRecurringWebWrapper.tsx uses a default export even though it is not a Next.js page.tsx or layout.tsx file. • This violates the requirement to prefer named exports across the codebase (except where Next.js requires defaults). • Consumers importing this file via next/dynamic should be adjusted to import a named export instead of relying on default.
Agent prompt
## Issue description
`apps/web/modules/event-types/components/tabs/recurring/EventRecurringWebWrapper.tsx` uses `export default`, but default exports are only allowed in Next.js `page.tsx` / `layout.tsx` (and legacy `apps/web/app/pages/**/*.tsx`) per the compliance checklist.
## Issue Context
`apps/web/modules/event-types/components/EventTypeWebWrapper.tsx` dynamically imports this wrapper using a pattern that currently relies on the module’s default export.
## Fix Focus Areas
- apps/web/modules/event-types/components/tabs/recurring/EventRecurringWebWrapper.tsx[1-8]
- apps/web/modules/event-types/components/EventTypeWebWrapper.tsx[73-77]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
41
to
43
| const BookerWebWrapperComponent = (props: BookerWebWrapperAtomProps) => { | ||
| const router = useRouter(); | ||
| const pathname = usePathname(); | ||
| const searchParams = useSearchParams(); |
There was a problem hiding this comment.
2. Router removed, still used 🐞 Bug ✓ Correctness
• useRouter import and const router = useRouter() were removed from BookerWebWrapper, but router.push(...) is still called in multiple handlers. • This should fail TypeScript compilation (“Cannot find name 'router'”) and breaks booking navigation flows at runtime. • The useCallback dependency array also references router, compounding the compile error.
Agent prompt
### Issue description
`BookerWebWrapper` still uses `router.push(...)` but no longer imports/initializes `router`. This causes a compile-time failure and breaks booking navigation.
### Issue Context
This component is a client component and uses Next.js App Router hooks.
### Fix Focus Areas
- apps/web/modules/bookings/components/BookerWebWrapper.tsx[3-5]
- apps/web/modules/bookings/components/BookerWebWrapper.tsx[41-44]
- apps/web/modules/bookings/components/BookerWebWrapper.tsx[182-196]
- apps/web/modules/bookings/components/BookerWebWrapper.tsx[221-239]
### Suggested fix
1. Add `useRouter` back to the `next/navigation` import.
2. Re-add `const router = useRouter();` near the top of `BookerWebWrapperComponent`.
3. Ensure `onOverlaySwitchStateChange` deps remain correct (`[router]` is fine once defined).
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
+41
to
+59
| export function sortHosts( | ||
| hostA: { priority: number | null; weight: number | null }, | ||
| hostB: { priority: number | null; weight: number | null }, | ||
| isRRWeightsEnabled: boolean | ||
| ) { | ||
| const weightA = hostA.weight ?? 100; | ||
| const priorityA = hostA.priority ?? 2; | ||
| const weightB = hostB.weight ?? 100; | ||
| const priorityB = hostB.priority ?? 2; | ||
|
|
||
| if (isRRWeightsEnabled) { | ||
| if (weightA === weightB) { | ||
| return priorityA - priorityB; | ||
| } else { | ||
| return weightB - weightA; | ||
| } | ||
| } else { | ||
| return priorityB - priorityA; | ||
| } |
There was a problem hiding this comment.
3. Host sorting order flipped 🐞 Bug ✓ Correctness
• sortHosts was moved into packages/lib/bookings/hostGroupUtils.ts, but the tie-break logic changed: when RR weights are enabled and weights are equal, it now sorts priority ascending. • Priority values are defined as 0=lowest … 4=highest; elsewhere (non-weighted sorting) priority is sorted descending. • This inconsistency can reorder hosts incorrectly when enabling RR weights, especially since default weights are equal (100), making the tie-break path common.
Agent prompt
### Issue description
`sortHosts` now sorts priorities in ascending order when RR weights are enabled and weights are equal, but priority values indicate higher numbers are higher priority and other branches sort priority descending. This can reorder hosts incorrectly.
### Issue Context
The sort function is used in both web UI and atoms form initialization, and is called with `isRRWeightsEnabled=true`.
### Fix Focus Areas
- packages/lib/bookings/hostGroupUtils.ts[41-59]
### Suggested fix
1. Change the equal-weight branch to return `priorityB - priorityA` (descending) to match the non-weighted branch and priority semantics.
2. (Optional but recommended) Add a small test ensuring:
- when weights are equal and RR weights enabled, higher `priority` sorts first
- when weights differ, higher `weight` sorts first
- when RR weights disabled, higher `priority` sorts first
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
| }; | ||
|
|
||
| export default EventLimitsTabWebWrapper; | ||
| export default EventLimitsTabWebWrapper; No newline at end of file |
There was a problem hiding this comment.
4. Missing final newline 🐞 Bug ⛯ Reliability
• Two files are flagged in the PR diff as missing a trailing newline. • Repo .editorconfig requires insert_final_newline = true, so CI formatting/lint checks may fail. • Fix is trivial: add a newline at EOF for both files.
Agent prompt
### Issue description
Two files are missing a final newline, which violates `.editorconfig` and can fail formatting/lint checks.
### Issue Context
Git diff indicates `\ No newline at end of file` for both wrappers.
### Fix Focus Areas
- apps/web/modules/event-types/components/tabs/limits/EventLimitsTabWebWrapper.tsx[1-8]
- apps/web/modules/event-types/components/tabs/recurring/EventRecurringWebWrapper.tsx[1-8]
### Suggested fix
Ensure each file ends with a newline after the final `export default ...;` line.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR from agentic-review-benchmarks#9