Refactor FXIOS-12796 [Swift 6 Migration] Fix main actor isolation warnings that are Swift 6 errors in the XCUITests suite - Batch 2#2
Refactor FXIOS-12796 [Swift 6 Migration] Fix main actor isolation warnings that are Swift 6 errors in the XCUITests suite - Batch 2#2
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 81d28b8f57
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import XCTest | ||
|
|
||
| @MainActor |
There was a problem hiding this comment.
Root AGENTS.md rule 1 requires every .swift file to begin with the exact Mozilla Public License v2.0 header. A11yUtils.swift now starts with import XCTest and no header, which violates that compliance rule and can break licensing checks or CI gates that enforce it. Please restore the exact MPL header at the top of this file.
Useful? React with 👍 / 👎.
| override func setUp() async throws { | ||
| continueAfterFailure = false | ||
| setUpExperimentVariables() | ||
| setUpApp() | ||
| setUpExperimentVariables() | ||
| setUpLaunchArguments() |
There was a problem hiding this comment.
FeatureFlaggedTestSuite.setUp() now calls setUpApp() before setUpExperimentVariables(), but setUpApp() immediately reads jsonFileName/featureName (IUO properties) to build launch arguments. In subclasses that set those values inside setUpExperimentVariables(), this reordering means the IUOs are still nil and will trap at runtime or cause missing experiment/feature arguments. The previous order ensured the variables were set before use.
Useful? React with 👍 / 👎.
2 participants
Benchmark PR from agentic-review-benchmarks#2