Skip to content

Code Review Bench PR #31309 - Bugfix FXIOS-14456 #31308 ⁃ Fix test failing on XCode 26.2 to enable using this version on Bitrise#12

Open
tomerqodo wants to merge 4 commits intobase_pr_31309_20260125_9363from
corrupted_pr_31309_20260125_9363
Open

Code Review Bench PR #31309 - Bugfix FXIOS-14456 #31308 ⁃ Fix test failing on XCode 26.2 to enable using this version on Bitrise#12
tomerqodo wants to merge 4 commits intobase_pr_31309_20260125_9363from
corrupted_pr_31309_20260125_9363

Conversation

@tomerqodo
Copy link
Copy Markdown

Code Review Bench PR mozilla-mobile#31309

Original PR Title: Bugfix FXIOS-14456 mozilla-mobile#31308 ⁃ Fix test failing on XCode 26.2 to enable using this version on Bitrise
Original PR Description: ## 📜 Tickets
Jira ticket
Github issue

💡 Description

  • WebKit tightened internal checks for WKFrameInfo and WKSecurityOrigin, making it unsafe or impossible to construct mocks for these types. Our previous mocks began crashing because they no longer satisfied WebKit’s required internal state.
  • Add WebKitTestHelpers class that captures real frame/origin objects from a lightweight navigation in a real WKWebView, ensuring compatibility with the new SDK and stabilizing the media-capture permission tests.

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

Original PR URL: mozilla-mobile#31309

This was referenced Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants