Clean up lookahead-related code#3
Clean up lookahead-related code#3tomerqodo wants to merge 7 commits intoaugment_full_base_clean_up_lookahead-related_code_pr3from
Conversation
Co-authored-by: Ozan Tezcan <ozantezcan@gmail.com>
🤖 Augment PR SummarySummary: This PR streamlines cluster slot “lookahead” handling by centralizing slot extraction and unifying sentinel return codes. 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| /* Allocate temporary buffer for slot tracking */ | ||
| int *slot_buffer = malloc(sizeof(int) * keys_result->numkeys); | ||
|
|
||
| for (int j = 0; j <= keys_result->numkeys; j++) { |
There was a problem hiding this comment.
The loop condition iterates one past keys_result->numkeys, which will access keys_result->keys[j] and write slot_buffer[j] out of bounds on the final iteration (potential crash/memory corruption).
🤖 Was this useful? React with 👍 or 👎
| for (int j = 0; j < keys_result->numkeys; j++) { | ||
|
|
||
| /* Allocate temporary buffer for slot tracking */ | ||
| int *slot_buffer = malloc(sizeof(int) * keys_result->numkeys); |
There was a problem hiding this comment.
Using plain malloc here can return NULL on OOM and would lead to a NULL dereference in the loop; Redis code typically relies on its allocator/oom handling for these paths.
🤖 Was this useful? React with 👍 or 👎
|
|
||
| *slot = INVALID_CLUSTER_SLOT; | ||
| if (num_keys >= 0) | ||
| if (num_keys > 0) { |
There was a problem hiding this comment.
extractKeysAndSlot() only writes to *slot when num_keys > 0, so callers that don’t pre-initialize *slot will observe a stale/undefined slot value when num_keys == 0 despite the function’s contract saying it returns the slot via *slot.
🤖 Was this useful? React with 👍 or 👎
2 participants
Benchmark PR from agentic-review-benchmarks#3