Clean up lookahead-related code

[tomerqodo]

Benchmark PR from agentic-review-benchmarks#3

---

Note

Unifies slot handling to improve consistency across cluster operations.

• Introduces CLUSTER_CROSSSLOT and uses INVALID_CLUSTER_SLOT in place of legacy GETSLOT_* values; removes old macros from server.h
• Refactors extractSlotFromKeysResult and updates getSlotFromCommand to delegate to it for consistent slot derivation
• Aligns cross-slot and no-keys logic in cluster_asm.c (propagation checks), cluster_slot_stats.c (stats gating), and command preprocessing in server.c
• Adjusts callers to treat INVALID_CLUSTER_SLOT as no-keys/disabled-cluster and CLUSTER_CROSSSLOT as cross-slot errors; minor comment clarifications in networking.c

^{Written by Cursor Bugbot for commit cfae119. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

[cursor]

Off-by-one error causes out-of-bounds memory access

High Severity

The loop condition j <= keys_result->numkeys iterates one too many times. When j equals numkeys, both keys_result->keys[j] and slot_buffer[j] are accessed out of bounds. The slot_buffer is allocated with numkeys elements (indices 0 to numkeys-1), and keys_result->keys similarly has numkeys entries. The condition should be j < keys_result->numkeys to match all other similar loops in the codebase.

 

[cursor]

Unused slot_buffer allocation is dead code

Low Severity

The slot_buffer array is allocated and written to but never read. The function's logic only compares first_slot with this_slot to detect cross-slot keys—the values stored in slot_buffer serve no purpose. The buffer is allocated, populated on each iteration, and then freed without ever being used for any computation or return value.

Additional Locations (1)

• src/cluster.c#L1123-L1124