Skip to content

fix(install): user can specify which docker.sock to mount when run install script#553

Open
chanjarster wants to merge 1 commit intoagentscope-ai:mainfrom
chanjarster:patch-1
Open

fix(install): user can specify which docker.sock to mount when run install script#553
chanjarster wants to merge 1 commit intoagentscope-ai:mainfrom
chanjarster:patch-1

Conversation

@chanjarster
Copy link
Copy Markdown

fix #552 (install.sh choose a wrong docker.sock on macos machine which uses colima managed docker)

Copy link
Copy Markdown
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the PowerShell script to ensure consistent logic

@chanjarster
Copy link
Copy Markdown
Author

Please also update the PowerShell script to ensure consistent logic

There is no CONTAINER_SOCK variable in hiclaw-install.ps1, and is hard-coded to -v "//var/run/docker.sock:/var/run/docker.sock":

if ($config.DOCKER_PROXY -eq "1") {
$proxyImage = $script:DOCKER_PROXY_IMAGE
Write-Log "Starting Docker API proxy..."
docker rm -f hiclaw-docker-proxy *>$null
docker run -d --name hiclaw-docker-proxy `
--network hiclaw-net `
-v "//var/run/docker.sock:/var/run/docker.sock" `
--security-opt label=disable `
$(if ($config.PROXY_ALLOWED_REGISTRIES) { @("-e", "HICLAW_PROXY_ALLOWED_REGISTRIES=$($config.PROXY_ALLOWED_REGISTRIES)") }) `
--restart unless-stopped `
$proxyImage
$dockerArgs += @("-e", "HICLAW_CONTAINER_API=http://hiclaw-docker-proxy:2375")
Write-Log (Get-Msg "docker_proxy.selected_enabled")
} else {
$dockerArgs += @("-v", "//var/run/docker.sock:/var/run/docker.sock")
Write-Log (Get-Msg "install.socket_detected" -f "//var/run/docker.sock")
}

maybe there is no need to specify docker.sock on Windows?

I'm not familiar with docker on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] install.sh choose a wrong docker.sock on macos machine which uses colima managed docker

2 participants