feat: improve embedded install with env reuse, static services, and container naming#597
Open
johnlanni wants to merge 4 commits intoagentscope-ai:hiclaw-controller-refactorfrom
Conversation
…ontainer naming - Load existing hiclaw-manager.env before defaults so secrets and config survive re-installs (matching hiclaw-install.sh behavior) - Write all key variables to env file with chmod 600 - Normalize legacy domain values missing :8080 port suffix - Fix manager container name: "default" manager uses "hiclaw-manager" (no suffix) so make uninstall/test scripts can find it - Add ContainerName override to CreateRequest for explicit naming - Use static service sources (not DNS) for Tuwunel and Element Web in embedded mode, matching setup-higress.sh behavior - Add HICLAW_OPENAI_BASE_URL support: read from env, create DNS service source with correct protocol, configure openai-compat provider - Add APT_MIRROR build arg to Dockerfile.embedded for faster builds - Fix test scripts to detect hiclaw-manager container (not just hiclaw-manager-*) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Element Web runs in the user's browser, so it needs to reach Matrix via the host-exposed gateway port (127.0.0.1:18080), not the internal container domain (matrix-local.hiclaw.io:8080) which browsers can't resolve. Add HICLAW_ELEMENT_HOMESERVER_URL to override the base_url in start-element-web.sh, and set it in the embedded install script. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Test 14 (git-collab) runs git commands inside the controller container. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Without this, re-installs lose the OpenAI base URL configuration. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hiclaw-manager.envbefore defaults so secrets and config survive re-installs (matchinghiclaw-install.shbehavior)hiclaw-manager(no suffix) somake uninstall/test scripts can find itsetup-higress.shbehaviorHICLAW_OPENAI_BASE_URLsupport with correct protocol detection for openai-compat provider:8080port suffixAPT_MIRRORbuild arg toDockerfile.embeddedfor faster builds in Chinahiclaw-managercontainer (not justhiclaw-manager-*)Test plan
make build-embedded— verify APT mirror speeds up buildmake install-embedded && make test-embedded— verify full flowmake install-embeddedwith existing env file — verify secrets are reusedmake uninstall-embedded— verifyhiclaw-managercontainer is cleaned upHICLAW_OPENAI_BASE_URL=https://coding.dashscope.aliyuncs.com/v1creates correct service source with https protocol🤖 Generated with Claude Code