Skip to content

fix(controller): clarify leaderWorkerSpec runtime hardcode (#761)#800

Open
nillikechatchat wants to merge 1 commit into
agentscope-ai:mainfrom
nillikechatchat:fix/team-worker-runtime-issue-761
Open

fix(controller): clarify leaderWorkerSpec runtime hardcode (#761)#800
nillikechatchat wants to merge 1 commit into
agentscope-ai:mainfrom
nillikechatchat:fix/team-worker-runtime-issue-761

Conversation

@nillikechatchat
Copy link
Copy Markdown
Contributor

Summary

This PR adds a clarifying comment to leaderWorkerSpec() in the team controller, explaining why the Runtime is hardcoded to "copaw":

  1. LeaderSpec has no runtime field defined in the API types
  2. The team-leader-agent/ template only ships a CoPaw build

Background

Issue #761 reported that Team member Workers were ignoring the runtime field and always using "copaw". The main fix for this issue (changing teamWorkerSpecToWorkerSpec() to pass through w.Runtime) was already applied in the upstream repository.

This PR addresses the secondary request in the issue comments to add a comment explaining the intentional hardcode in leaderWorkerSpec().

Changes

  • hiclaw-controller/internal/controller/team_controller.go: Added explanatory comment above leaderWorkerSpec() function

Related Issues

agentscope-ai#761)

This commit adds a clarifying comment to leaderWorkerSpec() explaining why
the Runtime is hardcoded to "copaw":

1. LeaderSpec has no runtime field defined in the API types
2. The team-leader-agent/ template only ships a CoPaw build

The sibling function teamWorkerSpecToWorkerSpec() was already fixed to
pass through w.Runtime (fixing the main issue reported in agentscope-ai#761). This
change addresses the secondary request in the issue comments to add
a comment explaining the intentional hardcode in leaderWorkerSpec().

Related: agentscope-ai#690 (same pattern of Team CR field dropping)
@github-actions
Copy link
Copy Markdown
Contributor

📊 CI Metrics Report

Summary

Metric Current Baseline Change
LLM Calls 112 86 +26 ↑ +30.2%
Input Tokens 3575879 3825223 -249344 ↓ -6.5%
Output Tokens 23525 19253 +4272 ↑ +22.2%
Total Tokens 3599404 3844476 -245072 ↓ -6.4%

By Role

Role Metric Current Baseline Change
🧠 Manager LLM Calls 78 75 +3 ↑ +4.0%
Input Tokens 2736732 3572217 -835485 ↓ -23.4%
Output Tokens 15690 16994 -1304 ↓ -7.7%
Total Tokens 2752422 3589211 -836789 ↓ -23.3%
🔧 Workers LLM Calls 34 11 +23 ↑ +209.1%
Input Tokens 839147 253006 +586141 ↑ +231.7%
Output Tokens 7835 2259 +5576 ↑ +246.8%
Total Tokens 846982 255265 +591717 ↑ +231.8%

Per-Test Breakdown

Test Mgr Calls Wkr Calls Δ Calls Mgr In Wkr In Mgr Out Wkr Out Δ Tokens Trend
02-create-worker 13 0 -4 ↓ -23.5% 377524 0 3380 0 -155667 ↓ -29.0% ✅ improved
03-assign-task 13 7 +5 ↑ +33.3% 432075 163892 2191 1428 +15695 ↑ +2.7% ⚠️ regressed
04-human-intervene 16 0 +3 ↑ +23.1% 467444 0 2587 0 -73587 ↓ -13.5% ⚠️ regressed
05-heartbeat 8 0 +1 ↑ +14.3% 291505 0 2113 0 -48745 ↓ -14.2% ⚠️ regressed
06-multi-worker 28 27 +21 ↑ +61.8% 1168184 675255 5419 6407 +17232 ↑ +0.9% ⚠️ regressed

Trends

1 test(s) improved (fewer LLM calls)
⚠️ 4 test(s) regressed (more LLM calls)


Generated by HiClaw CI on 2026-05-12 10:29:59 UTC


📦 Download debug logs & test artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant