fix(controller): clarify leaderWorkerSpec runtime hardcode (#761)#800
Open
nillikechatchat wants to merge 1 commit into
Open
fix(controller): clarify leaderWorkerSpec runtime hardcode (#761)#800nillikechatchat wants to merge 1 commit into
nillikechatchat wants to merge 1 commit into
Conversation
agentscope-ai#761) This commit adds a clarifying comment to leaderWorkerSpec() explaining why the Runtime is hardcoded to "copaw": 1. LeaderSpec has no runtime field defined in the API types 2. The team-leader-agent/ template only ships a CoPaw build The sibling function teamWorkerSpecToWorkerSpec() was already fixed to pass through w.Runtime (fixing the main issue reported in agentscope-ai#761). This change addresses the secondary request in the issue comments to add a comment explaining the intentional hardcode in leaderWorkerSpec(). Related: agentscope-ai#690 (same pattern of Team CR field dropping)
Contributor
📊 CI Metrics ReportSummary
By Role
Per-Test Breakdown
Trends✅ 1 test(s) improved (fewer LLM calls) Generated by HiClaw CI on 2026-05-12 10:29:59 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a clarifying comment to
leaderWorkerSpec()in the team controller, explaining why the Runtime is hardcoded to "copaw":LeaderSpechas no runtime field defined in the API typesteam-leader-agent/template only ships a CoPaw buildBackground
Issue #761 reported that Team member Workers were ignoring the
runtimefield and always using "copaw". The main fix for this issue (changingteamWorkerSpecToWorkerSpec()to pass throughw.Runtime) was already applied in the upstream repository.This PR addresses the secondary request in the issue comments to add a comment explaining the intentional hardcode in
leaderWorkerSpec().Changes
hiclaw-controller/internal/controller/team_controller.go: Added explanatory comment aboveleaderWorkerSpec()functionRelated Issues