Skip to content

feat: add getVersion() method #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haosenwang1018 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

feat: add getVersion() method #851

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions agentscope-core/src/main/java/io/agentscope/core/Version.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,13 @@ public static String getUserAgent() {
"agentscope-java/%s; java/%s; platform/%s",
VERSION, System.getProperty("java.version"), System.getProperty("os.name"));
}

/**
* Returns the AgentScope Java version.
*
* @return version string (e.g., "1.0.10-SNAPSHOT")
*/
public static String getVersion() {
return VERSION;
}
Comment on lines +53 to +55
Copy link

@gemini-code-assist gemini-code-assist bot Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This method is redundant as it provides a getter for the VERSION constant, which is already public. Having two public access points for the same value can lead to inconsistent usage across the codebase. For better encapsulation, the VERSION constant should be made private, and this getter should be the sole public access point. Please consider addressing this in a follow-up change to improve the API design.

}
Loading