Skip to content

Add NacosSkillRepository#902

Merged
chickenlj merged 11 commits intoagentscope-ai:mainfrom
qiacheng7:main
Mar 10, 2026
Merged

Add NacosSkillRepository#902
chickenlj merged 11 commits intoagentscope-ai:mainfrom
qiacheng7:main

Conversation

@qiacheng7
Copy link
Contributor

提供 NacosSkillRepository,实现 AgentSkillRepository,从 Nacos 读取 Skill(只读)

@qiacheng7 qiacheng7 requested a review from a team March 10, 2026 01:51
@cla-assistant
Copy link

cla-assistant bot commented Mar 10, 2026

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Mar 10, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 95.08197% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ntscope/core/nacos/skill/NacosSkillRepository.java 93.02% 2 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@shiyiyue1102
Copy link
Contributor

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

sign CLA pls.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new Nacos-backed AgentSkillRepository implementation so AgentScope can read Skills from Nacos (read-only), and wires the new module into the build/distribution BOMs.

Changes:

  • Add new agentscope-extensions-nacos-skill module implementing NacosSkillRepository and a SkillAgentSkill converter.
  • Register the new module in the Nacos extensions parent POM and include it in the BOM and agentscope-all distribution.
  • Update the managed nacos-client version in the dependencies BOM.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
agentscope-extensions/agentscope-extensions-nacos/pom.xml Adds the new agentscope-extensions-nacos-skill module to the reactor build.
agentscope-extensions/agentscope-extensions-nacos/agentscope-extensions-nacos-skill/src/main/java/io/agentscope/core/nacos/skill/NacosSkillToAgentSkillConverter.java Introduces conversion logic from Nacos AI Skill model to AgentSkill.
agentscope-extensions/agentscope-extensions-nacos/agentscope-extensions-nacos-skill/src/main/java/io/agentscope/core/nacos/skill/NacosSkillRepository.java Adds the Nacos-based repository implementation for loading skills.
agentscope-extensions/agentscope-extensions-nacos/agentscope-extensions-nacos-skill/pom.xml Declares the new skill module artifact and dependencies.
agentscope-distribution/agentscope-bom/pom.xml Adds the new artifact to the AgentScope BOM.
agentscope-distribution/agentscope-all/pom.xml Includes the new module as an optional dependency in the “all” distribution.
agentscope-dependencies-bom/pom.xml Bumps the managed nacos-client version used across the repo.

Copy link
Collaborator

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit 10c8e58 into agentscope-ai:main Mar 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants