fix(openai): handle null statusCode in HttpTransportException to prevent NPE#928
Open
shlokmestry wants to merge 2 commits intoagentscope-ai:mainfrom
Open
fix(openai): handle null statusCode in HttpTransportException to prevent NPE#928shlokmestry wants to merge 2 commits intoagentscope-ai:mainfrom
shlokmestry wants to merge 2 commits intoagentscope-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.0.10-SNAPSHOT
Fixes a NullPointerException in OpenAIClient.stream() caused by auto-unboxing
a nullable Integer when HttpTransportException has no HTTP status code
(e.g. connection failure, DNS error, timeout).
The existing code passed getStatusCode() (return type Integer, nullable)
directly to OpenAIException.create(int, ...), which throws an NPE when
statusCode is null.
Fix: Added a null check before accessing getStatusCode(). If null, falls back
to new OpenAIException(msg, ex) instead of crashing.
Fixes #891