fix: get package version from installed module instead of pyproject.toml#438
fix: get package version from installed module instead of pyproject.toml#438rayrayraykk merged 2 commits intoagentscope-ai:mainfrom
Conversation
Summary of ChangesHello @bcfre, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the package version retrieval mechanism within Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a bug where the package version could not be retrieved when installed via pip/uv. The approach of first trying to get the version from the installed module and falling back to parsing pyproject.toml is sound. I've provided one suggestion to use importlib.metadata which is the standard and more robust way to get an installed package's version in modern Python.
|
@all-contributors please add @bcfre for code |
|
I've put up a pull request to add @bcfre! 🎉 |
Description
[Describe what this PR does and why]
Fix _get_package_version() failing to retrieve version when the package is installed via pip/uv.
Problem: The original implementation only attempts to find and parse
pyproject.tomlto get the package version. This causes two issues:Missing
pyproject.toml: Whenagentscope-runtimeis installed into a virtual environment (e.g.,.venvvia uv or pip), thepyproject.tomlfile does not exist in the installed package location, causing the function to return an empty string.Wrong
pyproject.toml: If the user's local project has its ownpyproject.tomlfile, the function may mistakenly read the user's project version instead of theagentscope-runtimeversion.Solution: Prioritize importing the version from
agentscope_runtime.versionmodule (which is always available in the installed package), and only fallback to parsingpyproject.tomlfor development scenarios where running from source.Related Issue: N/A
Security Considerations: N/A
Type of Change
Component(s) Affected
Checklist
Testing
[How to test these changes]
Additional Notes
[Optional: any other context]