Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps the runtime version and adds an early-return guard in SandboxManager.create() to stop creating new sandboxes when the configured max_sandbox_instances cap has been reached.
Changes:
- Bump package/runtime version to
1.1.2b1/v1.1.2b1. - Add a limit check in
SandboxManager.create()that logs and returnsNonewhen the active instance count reachesmax_sandbox_instances.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/agentscope_runtime/version.py |
Updates runtime __version__ constant. |
src/agentscope_runtime/sandbox/manager/sandbox_manager.py |
Adds guard to enforce the max sandbox instance limit in create(). |
pyproject.toml |
Updates package version metadata. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this PR does and why]
Related Issue: Fixes #[issue_number] or Relates to #[issue_number]
Security Considerations: [If applicable, especially for sandbox changes]
Type of Change
Component(s) Affected
Checklist
Testing
[How to test these changes]
Additional Notes
[Optional: any other context]