fix sandbox reap session#463
Merged
rayrayraykk merged 2 commits intoagentscope-ai:mainfrom Mar 19, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts sandbox session restore behavior to keep “old” recycled container records around for compatibility, while redirecting lookups from those old identities to the newly restored containers.
Changes:
- Add a new container lifecycle state
REPLACEDplus aredirect_tofield onContainerModel. - Update sandbox restore flow to mark old recycled container records as
REPLACED(instead of deleting them) and haveget_info()follow redirects. - Treat
REPLACEDas a terminal/cleanup-eligible state in relevant manager flows (cleanup, heartbeat recycle marking, released-record GC).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/agentscope_runtime/sandbox/model/container.py | Adds REPLACED state and redirect_to metadata on container records. |
| src/agentscope_runtime/sandbox/manager/sandbox_manager.py | Implements redirect-following in get_info(), marks old records as REPLACED during restore, and updates cleanup/GC logic for the new state. |
| src/agentscope_runtime/sandbox/manager/heartbeat_mixin.py | Ensures heartbeat recycle logic and restore checks treat REPLACED appropriately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this PR does and why]
Related Issue: Fixes #[issue_number] or Relates to #[issue_number]
Security Considerations: [If applicable, especially for sandbox changes]
Type of Change
Component(s) Affected
Checklist
Testing
[How to test these changes]
Additional Notes
[Optional: any other context]