Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Bumps the AgentScope Runtime package/runtime version to 1.1.2b3 and adjusts an exception handler in the tracing async-generator wrapper.
Changes:
- Update runtime
__version__tov1.1.2b3. - Update packaging version in
pyproject.tomlto1.1.2b3. - Change a tracing wrapper re-raise block from
except Exceptiontoexcept BaseException.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/agentscope_runtime/version.py |
Bumps runtime __version__ to v1.1.2b3. |
pyproject.toml |
Bumps package version to 1.1.2b3. |
src/agentscope_runtime/engine/tracing/wrapper.py |
Broadens an exception handler around async iteration in the tracing wrapper. |
Comment on lines
+469
to
470
| except BaseException as e: | ||
| raise e |
There was a problem hiding this comment.
Catching BaseException here is unnecessarily broad (it includes asyncio.CancelledError, KeyboardInterrupt, SystemExit) and the handler just re-raises anyway. This also uses raise e, which rewrites the traceback; prefer removing the try/except entirely, or at minimum catch Exception and use bare raise to preserve the original traceback/cancellation semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this PR does and why]
Related Issue: Fixes #[issue_number] or Relates to #[issue_number]
Security Considerations: [If applicable, especially for sandbox changes]
Type of Change
Component(s) Affected
Checklist
Testing
[How to test these changes]
Additional Notes
[Optional: any other context]