Skip to content

Fix in learn to ask#107

Merged
rayrayraykk merged 3 commits intoagentscope-ai:mainfrom
chenyushuo:fix/learn_to_ask
Jan 20, 2026
Merged

Fix in learn to ask#107
rayrayraykk merged 3 commits intoagentscope-ai:mainfrom
chenyushuo:fix/learn_to_ask

Conversation

@chenyushuo
Copy link
Contributor

📝 PR Type

  • Add new sample
  • Update existing sample
  • Add new test cases
  • Fix test failures
  • Documentation/Configuration update

📚 Description

[Please briefly describe the background, changes, and purpose of this PR. For example:

  • Added game_werewolves to demonstrate XYZ functionality in agentscope.
  • Fixed test failures in game_test.py caused by agentscope interface changes.
  • Updated dependency installation instructions in README.md of agentscope-samples.]

🧪 Testing Validation

[Please explain how to validate the changes:

  1. How to run the added/modified test cases?
  2. Is integration testing with agentscope required?
  3. Has code been formatted (e.g., pre-commit)?]

✅ Checklist

Please complete the following checks before submitting the PR:

  • All sample code has been formatted with pre-commit run --all-files
  • All new/modified test cases have passed (run pytest tests/)
  • Test coverage has not decreased (if applicable)
  • Sample code follows agentscope best practices (e.g., config management, logging)
  • Related documentation in agentscope-samples has been updated (e.g., README.md)

@chenyushuo chenyushuo requested a review from a team January 20, 2026 02:31
@gemini-code-assist
Copy link

Summary of Changes

Hello @chenyushuo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the learn_to_ask example by providing clearer operational details and refining its underlying code. It introduces estimated training costs and token usage in the documentation, offering users better transparency, and simplifies model configuration by removing a redundant parameter.

Highlights

  • Documentation Update: The README.md for the learn_to_ask example now includes important details regarding training configuration, estimated token consumption (112 million tokens), and approximate cost ($18) when utilizing Tinker for 4 epochs.
  • Code Refinement: The main.py file has been updated to remove the reasoning_parser=None argument from ModelConfig instances, streamlining the model configuration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the 'learn_to_ask' example. The main changes involve removing the reasoning_parser parameter from TunerModelConfig in main.py, likely to align with recent API updates. Additionally, the README.md file has been updated to include estimated token consumption and cost when using the Tinker backend. My review includes a minor suggestion to improve the formatting of the cost information in the README for better clarity.

chenyushuo and others added 2 commits January 20, 2026 12:00
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@rayrayraykk rayrayraykk merged commit 311ddff into agentscope-ai:main Jan 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants