fix(memory): skip empty assistant turns when loading session state#1436
Open
octo-patch wants to merge 1 commit intoagentscope-ai:mainfrom
Open
fix(memory): skip empty assistant turns when loading session state#1436octo-patch wants to merge 1 commit intoagentscope-ai:mainfrom
octo-patch wants to merge 1 commit intoagentscope-ai:mainfrom
Conversation
When an agent crashes mid-response (e.g. during MCP SSE teardown), an empty assistant message may be saved to the session JSON. On the next load, replaying this empty turn to the LLM API causes a 400 error: 'assistant must provide content or tool_calls'. Filter out assistant messages with no content during load_state_dict so corrupt session state no longer causes hard failures on restart. Fixes agentscope-ai#1426
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1426
Problem
When an agent crashes mid-response (e.g., during MCP SSE teardown), AgentScope saves an empty assistant message to the session JSON. On the next load, the full session history including the empty turn is replayed to the LLM API, which returns:
400 - messages[N] assistant must provide content or tool_callsThis causes a hard crash on every subsequent invocation until the session file is manually deleted.
Solution
In
InMemoryMemory.load_state_dict, skip assistant messages whosecontentis falsy (empty string or empty list) when deserializing saved session state.Testing