Conversation
…tory details and report structure
…proved documentation synchronization
…Enum for better type handling because not yet supported in py3.10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve code readability, add documentation, and enhance type annotations. The most important changes include adding emoji labels to GitHub Action steps, updating type annotations and documentation in the
color_correctionmodule, and defining custom types for image processing.Enhancements to GitHub Actions:
.github/workflows/docs.yml: Added emoji labels to the names of the steps to improve readability. [1] [2]Type Annotations and Documentation:
color_correction/schemas/custom_types.py: Added type annotations for image processing, includingColorPatchType,ImageType,ImageBGR, andImageRGB.color_correction/schemas/det_yv8.py: Added detailed docstrings for theDetectionResultmodel anddraw_detectionsmethod to provide better context and usage information. [1] [2] [3]color_correction/schemas/device.py: ChangedEnumtoStrEnumforGPUTypeandCPUArchitectureclasses and added detailed docstrings forDeviceSpecs. [1] [2]color_correction/services/color_correction.py: Updated type annotations to use custom types (ImageBGR) and added detailed docstrings for methods to improve clarity. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Code Cleanup:
color_correction/schemas/images.py: Removed redundant type annotations that are now defined incustom_types.py.color_correction/core/correction/polynomial.py: Improved docstrings formatting for better readability. [1] [2]New Makefile Targets:
Makefile: Added new targetslist-installed,sync-docs, andsync-allto facilitate development workflows.