Skip to content

feat: validation and signing of GERs on aggsender-validator #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
goran-ethernal wants to merge 7 commits into
base: develop
Choose a base branch
from

fix: UT

ee80a70
Select commit
Loading
Failed to load commit list.
Draft

feat: validation and signing of GERs on aggsender-validator #1317

fix: UT
ee80a70
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Dec 2, 2025 in 32s

Quality Gate failed

Failed conditions
35.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 186 in aggsender/aggsender.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=agglayer_aggkit&issues=AZqh51DYBKDjml9YAYJ7&open=AZqh51DYBKDjml9YAYJ7&pullRequest=1317

Check warning on line 101 in aggsender/query/ger_query.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the 'Get' prefix from this function name. 

See more on https://sonarcloud.io/project/issues?id=agglayer_aggkit&issues=AZrflZmcFYDHzj48-lKR&open=AZrflZmcFYDHzj48-lKR&pullRequest=1317

Check warning on line 56 in aggsender/query/ger_query.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the 'Get' prefix from this function name. 

See more on https://sonarcloud.io/project/issues?id=agglayer_aggkit&issues=AZrflZmcFYDHzj48-lKQ&open=AZrflZmcFYDHzj48-lKQ&pullRequest=1317

Check warning on line 140 in aggsender/query/ger_query.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=agglayer_aggkit&issues=AZqh50-8BKDjml9YAYJ6&open=AZqh50-8BKDjml9YAYJ6&pullRequest=1317

Check warning on line 187 in aggsender/types/interfaces.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this interface to follow Go naming conventions for single-method interfaces. 

See more on https://sonarcloud.io/project/issues?id=agglayer_aggkit&issues=AZrflZgMFYDHzj48-lKP&open=AZrflZgMFYDHzj48-lKP&pullRequest=1317
View more details on SonarQubeCloud