fix: Enhance security in PolygonZkEVMBridge contract #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crStiv
commented
Apr 29, 2025
crStiv
commented
- Added nonReentrant modifier to claimAsset and claimMessage functions to prevent reentrancy attacks
- Improved _permit function to properly validate permit parameters and check execution results
- Added proper error handling for permit calls with custom error types
- Reordered operations in claimAsset to follow checks-effects-interactions pattern
- Added missing validation for expiry timestamps and permissions in token approvals
|
We require contributors/corporates @crStiv to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document |
|
|
how to sign it lmao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.