Draft proof aggregation #563
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alrevuelta
commented
Nov 6, 2025
alrevuelta
commented
Nov 6, 2025
alrevuelta
commented
Nov 6, 2025
alrevuelta
commented
Nov 6, 2025
alrevuelta
commented
Nov 6, 2025
alrevuelta
commented
Nov 6, 2025
alrevuelta
force-pushed
the
proof-aggregation
branch
from
0b9b1b2 to
5c26eaf
Compare
alrevuelta
commented
Nov 13, 2025
alrevuelta
commented
Nov 13, 2025
alrevuelta
commented
Nov 13, 2025
alrevuelta
commented
Nov 13, 2025
alrevuelta
commented
Nov 13, 2025
alrevuelta
commented
Nov 13, 2025
alrevuelta
commented
Nov 13, 2025
alrevuelta
commented
Nov 13, 2025
alrevuelta
commented
Nov 13, 2025
alrevuelta
commented
Nov 13, 2025
alrevuelta
commented
Nov 13, 2025
alrevuelta
commented
Nov 13, 2025
alrevuelta
commented
Nov 13, 2025
alrevuelta
commented
Nov 13, 2025
alrevuelta
commented
Nov 13, 2025
alrevuelta
force-pushed
the
proof-aggregation
branch
from
8dca736 to
3f49ab7
Compare
Comment on lines
165
to
186
| /// @notice Adds a verifier route. This enable proofs to be routed to this verifier. | ||
| /// @dev Only callable by the owner. The owner is responsible for ensuring that the specified | ||
| /// verifier is correct with a valid VERIFIER_HASH. Once a route to a verifier is added, it | ||
| /// cannot be removed. | ||
| /// @param pessimisticVKeySelector The verifier selector to add. | ||
| /// @param verifier The address of the verifier contract. This verifier MUST implement the | ||
| /// ISP1VerifierWithHash interface. | ||
| /// @param pessimisticVKey The verification key to be used for verifying pessimistic proofs. | ||
| function addPessimisticVKeyRoute( | ||
| bytes4 pessimisticVKeySelector, | ||
| address verifier, | ||
| bytes32 pessimisticVKey | ||
| ) external; | ||
|
|
||
| /// @notice Freezes a verifier route. This prevents proofs from being routed to this verifier. | ||
| /// @dev Only callable by the owner. Once a route to a verifier is frozen, it cannot be | ||
| /// unfrozen. | ||
| /// @param pessimisticVKeySelector The verifier selector to freeze. | ||
| function freezePessimisticVKeyRoute( | ||
| bytes4 pessimisticVKeySelector | ||
| ) external; | ||
|
|
Collaborator
There was a problem hiding this comment.
why delet and not replace the funcitons in the interface?¿
Collaborator
Author
There was a problem hiding this comment.
wops, missed this comment. fixed
cea36c2
alrevuelta
changed the base branch from
feature/v12
to
polpesconsensus-clean1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: Do not merge.
Notes (to be organized):
AgglayerGatewayreuses the storage slot of the deprecated PP route. Some types are reused as well. Roles are reused as well and names are not changed to avoid breaking changes. See comments.verifyPessimisticTrustedAggregatorno longer exists and nowverifyAggregatedProofTrustedshall be used. This new function wont work with PolygonPessimisticConsensus, as that path is deprecated as well.AgglayerGateway=v2.0.0AgglayerManager=v2.0.0VerifyAggregatedProof(bytes32 indexed prevArer, bytes32 indexed newArer)TODO: