Skip to content

Cleanup docker compose #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
alrevuelta wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Cleanup docker compose #576

alrevuelta wants to merge 1 commit into from

Conversation

@alrevuelta
Copy link
Collaborator

@alrevuelta alrevuelta commented Nov 26, 2025 •
edited
Loading

  • There were two almost identical scripts deploy-docker.sh and deploy-dockerv2.sh.
  • The only difference is that one uses "docker compose" and the other "docker-compose". This is due to a change in docker compose version.
  • This PR removes one script, since they are not needed and makes a small modification so that a single script works with both docker compose version. With "-" and without "-".

@alrevuelta alrevuelta changed the base branch from main to feature/v12 November 26, 2025 09:18
@alrevuelta alrevuelta marked this pull request as ready for review November 26, 2025 09:19
@krlosMata
Copy link
Member

krlosMata commented Dec 2, 2025

This cleanup will come with v13, I'd suggest to change the PR to draft

@alrevuelta alrevuelta marked this pull request as draft December 2, 2025 17:30
Base automatically changed from feature/v12 to develop December 19, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@invocamanman invocamanman Awaiting requested review from invocamanman invocamanman is a code owner

@krlosMata krlosMata Awaiting requested review from krlosMata krlosMata is a code owner

@ignasirv ignasirv Awaiting requested review from ignasirv

@laisolizq laisolizq Awaiting requested review from laisolizq laisolizq is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alrevuelta @krlosMata