Skip to content

feat: vault bridge v1.1.0#51

Merged
ZeroEkkusu merged 229 commits into
stagingfrom
tmp-lz-conflicts
Dec 24, 2025
Merged

feat: vault bridge v1.1.0#51
ZeroEkkusu merged 229 commits into
stagingfrom
tmp-lz-conflicts

Conversation

@ZeroEkkusu

@ZeroEkkusu ZeroEkkusu commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

Vault Bridge v1.1.0

  1. Create customized, upgradeable LayerZero OFT Adapter contracts
  2. Add support for new Bridge Provider (LayerZero)
  3. Add support for Bridged USDC Standard (LayerZero)
  4. Miscellaneous improvements and fixes
  5. Improve Bridge Provider documentation to aid Sales Team
  6. Improve deployments tracking to include all mainnets, testnets, and devnets
  7. Deploy permissionless faucet for mock underlying tokens

@ZeroEkkusu ZeroEkkusu changed the title feat: vault bridge v1.0.0 feat: vault bridge v1.1.0 Dec 11, 2025
@0xCVH 0xCVH requested a review from web3security December 12, 2025 09:02
@0xCVH

0xCVH commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

@web3security when you review this PR, can you please check and comment on the diff between the Certora auditted version and this (if any). Thanks

@ZeroEkkusu

Copy link
Copy Markdown
Contributor Author

@0xCVH @web3security This PR needed to be rebased, as you can see from the commit history. I highly recommend you clone the repository twice, and checkout the first one to the branch/commit that Certora indicated as the final in the report, checkout the second one to this branch/commit, and the run the following command in terminal:

diff -qr --exclude=".git" vault-bridge-certora vault-bridge-pr

@web3security web3security left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Here some relevant information about the review:

Here some recommendations anyway:

  • Deployment scripts should include addresses that are basic for this to run or simulate. I had to ask them through DM but in general I do recommend pushing addresses (or using input.json files as this repo was using at the beginning) so we avoid human error while using it. At least we need to ensure there is no error in the process since the security review.
  • Related to the above, it is recommended to enforce Layerzero endpoints usage from its website: Ethereum (https://docs.layerzero.network/v2/deployments/chains/ethereum) and Katana (https://docs.layerzero.network/v2/deployments/chains/katana)
  • Those not very familiar with the codebase will likely misunderstand that DeployNonDefaultOftAdapters.s.sol script is to deploy Ethereum mainnet instances (named primary chain) and DeployNonDefaultMintBurnOftAdapters.s.sol is for Katana's or secondary chains' instances.
  • It is worth mentioning that because Katana will use 0.5.1 the setBridge is not required so it is ok that last commit removed such reference. Anyways, future deployments would use it for other secondary chains, so this script should be reviewed in that sense.
Captura de pantalla 2025-12-18 a las 16 48 36

@0xCVH 0xCVH requested a review from Copilot December 18, 2025 16:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@ZeroEkkusu ZeroEkkusu marked this pull request as ready for review December 24, 2025 12:54
@ZeroEkkusu ZeroEkkusu merged commit f4af66c into staging Dec 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants