feat: vault bridge v1.1.0#51
Merged
Merged
Conversation
Signed-off-by: JDawg287 <sjcool420@hotmail.co.uk>
Signed-off-by: JDawg287 <sjcool420@hotmail.co.uk>
Signed-off-by: JDawg287 <sjcool420@hotmail.co.uk>
Signed-off-by: JDawg287 <sjcool420@hotmail.co.uk>
Signed-off-by: JDawg287 <sjcool420@hotmail.co.uk>
Signed-off-by: JDawg287 <sjcool420@hotmail.co.uk>
Signed-off-by: JDawg287 <sjcool420@hotmail.co.uk>
Signed-off-by: JDawg287 <sjcool420@hotmail.co.uk>
Contributor
|
@web3security when you review this PR, can you please check and comment on the diff between the Certora auditted version and this (if any). Thanks |
Contributor
Author
|
@0xCVH @web3security This PR needed to be rebased, as you can see from the commit history. I highly recommend you clone the repository twice, and checkout the first one to the branch/commit that Certora indicated as the final in the report, checkout the second one to this branch/commit, and the run the following command in terminal: |
web3security
approved these changes
Dec 18, 2025
web3security
left a comment
There was a problem hiding this comment.
LGTM.
Here some relevant information about the review:
- Due to rebase with 229 commits, I had reviewed the diff between certora audit version (commit 950e64d) and last commit of this PR (d863a96) that was pushed today.
- The diff can be found here: https://github.com/agglayer/vault-bridge/compare/950e64d..d863a96
- I also made a manual diff myself locally as suggested by Zero. (attached)
Here some recommendations anyway:
- Deployment scripts should include addresses that are basic for this to run or simulate. I had to ask them through DM but in general I do recommend pushing addresses (or using input.json files as this repo was using at the beginning) so we avoid human error while using it. At least we need to ensure there is no error in the process since the security review.
- Related to the above, it is recommended to enforce Layerzero endpoints usage from its website: Ethereum (https://docs.layerzero.network/v2/deployments/chains/ethereum) and Katana (https://docs.layerzero.network/v2/deployments/chains/katana)
- Those not very familiar with the codebase will likely misunderstand that DeployNonDefaultOftAdapters.s.sol script is to deploy Ethereum mainnet instances (named primary chain) and DeployNonDefaultMintBurnOftAdapters.s.sol is for Katana's or secondary chains' instances.
- It is worth mentioning that because Katana will use 0.5.1 the setBridge is not required so it is ok that last commit removed such reference. Anyways, future deployments would use it for other secondary chains, so this script should be reviewed in that sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vault Bridge v1.1.0