Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/serverless-sns-sqs-lambda.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
"use strict";
var hash = require('object-hash');

/**
* Parse a value into a number or set it to a default value.
Expand Down Expand Up @@ -157,10 +158,12 @@ Usage
}

const funcNamePascalCase = pascalCase(funcName);

const hashedFunctionName = hash(funcNamePascalCase).substring(0,10)
const uniqueName = `${hashedFunctionName}-${config.name}`

return {
...config,
name: config.name,
name: uniqueName,
funcName: funcNamePascalCase,
prefix:
config.prefix || `${this.serviceName}-${stage}-${funcNamePascalCase}`,
Expand Down
13 changes: 13 additions & 0 deletions lib/serverless-sns-sqs-lambda.test.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
"use strict";
var hash = require('object-hash');

const ServerlessSnsSqsLambda = require("./serverless-sns-sqs-lambda");
const Serverless = require("serverless/lib/Serverless");
Expand Down Expand Up @@ -57,6 +58,18 @@ describe("Test Serverless SNS SQS Lambda", () => {
}).toThrow(/name was \[undefined\]/);
});

it("should add the function name to the config name to make it unique", () => {
const functionName = 'MarketplaceSubscriptionConfirmation'
const funcNamePascalCase = functionName.slice(0, 1).toUpperCase() + functionName.slice(1);
const hashedFunctionName = hash(funcNamePascalCase).substring(0, 10)
const config = serverlessSnsSqsLambda.validateConfig(functionName, "stage", {
topicArn: "topicArn",
name: 'QueueName'
});

expect(config.name).toEqual(`${hashedFunctionName}-QueueName`)
});

it("should fail if topicArn is not passed", () => {
expect.assertions(1);
expect(() => {
Expand Down