Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add python-versioneer #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add python-versioneer #32

wants to merge 2 commits into from

Conversation

warner
Copy link
Contributor

@warner warner commented Jan 27, 2015

This installs versioneer-0.12 to manage versioning of the python binding. The old setup.py only gets the version right if you're building from a git checkout. Versioneer also handles building from a tarball produced by "setup.py sdist" or "git archive", including the tarballs automatically generated by github's "Releases" page.

This also makes curve25519.__version__ available to runtime code.

@warner
Copy link
Contributor Author

warner commented Jan 27, 2015

Oh, also, Versioneer is py2/py3-compatible. I don't think curve25519-donna is entirely py3-clean yet (I'll run some tests), but this won't make the situation worse.

@warner
Copy link
Contributor Author

warner commented Jan 27, 2015

Just tested it: curve25519-donna does seem to be py3-clean.

OTOH, Versioneer is not py2.5-compatible, so this would break the outstanding pull-request that adds py2.5 compatibility. If you land this one, you should probably WONTFIX the other one, and vice versa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant